httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r568326 - /httpd/httpd/trunk/server/log.c
Date Thu, 23 Aug 2007 20:32:17 GMT
Ruediger Pluem wrote:
> 
>> The original patch was dying on win32 as-a-service, because apr_file_open_stdout
>> fails without a stdout handle.
> 
> Ok, just for a non windows guy to understand: If httpd runs as a service we usually
> have no stdout handle and thus apr_file_open_stdout fails, correct?

Yup.  (No stdin/stderr either although we worked around those, already).

>> Now, I fixed blessing win32 services with a stdout handle /Device/null.
>> That much is now healthy.
> 
> Fixed in r568446, correct?

Right.

>> As I got to thinking about this, when the situation is this fatal, why kill
>> an otherwise perfectly healthy server?  Worst case, we have some piped loggers
>> which hang around longer than desired.  It's a situation which I wouldn't
>> want to bring down a production server for.
> 
> Ok, so the situation, that you cannot get the stdout handle, is very unlikely to
> happen after you fixed the windows stdout problem, correct?
> So if we deal with hanging piped loggers something else got terribly wrong.

Yes, but it could be as simple as someone's module closing stdout
inadvertently.  That shouldn't kill the server, would you agree?

Bill

Mime
View raw message