httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r568326 - /httpd/httpd/trunk/server/log.c
Date Thu, 23 Aug 2007 19:36:02 GMT
Ruediger Pluem wrote:
> 
> On 08/22/2007 01:28 AM, wrowe@apache.org wrote:
>> Author: wrowe
>> Date: Tue Aug 21 16:28:32 2007
>> New Revision: 568326
>>
>> URL: http://svn.apache.org/viewvc?rev=568326&view=rev
>> Log:
>> Refactor r452431, because this should not be fatal to starting
>> the server if it's horribly broken.  The alternative of returing
>> 'rc' in this case would be to open /dev/null as the error stream
>> for this generation of the server; and even more useless result.
> 
> Where do you see that /dev/null will be used as the error stream in this case?
> As far as I can see if log_child returns something different than APR_SUCCESS
> the whole open_logs hook fails and causes the process to die.

The original patch was dying on win32 as-a-service, because apr_file_open_stdout
fails without a stdout handle.

Now, I fixed blessing win32 services with a stdout handle /Device/null.
That much is now healthy.

As I got to thinking about this, when the situation is this fatal, why kill
an otherwise perfectly healthy server?  Worst case, we have some piped loggers
which hang around longer than desired.  It's a situation which I wouldn't
want to bring down a production server for.

Unfortunately, the perl-framework runs windows httpd as-a-console, and also
doesn't test piped logging, so this was never noticed when you and Joe had
originally offered up the solution.  Joy :)

Bill

Mime
View raw message