httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Graham Leggett" <minf...@sharp.fm>
Subject Re: [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
Date Fri, 31 Aug 2007 10:54:44 GMT
On Fri, August 31, 2007 12:41 pm, Martin Kraemer wrote:

> From the 2.2.x STATUS doc:
>    * mod_authn_dbd: Export any additional columns queried in the SQL
> select
>      into the environment with the name AUTHENTICATE_<COLUMN>. This brings
>      mod_authn_dbd behaviour in line with mod_authnz_ldap.
>      Trunk: http://svn.apache.org/viewvc?view=rev&revision=466865
>      +1: minfrin
>      niq: This wants a little tidying.  Use of 13 as a magic number (for a
>           strlen of something defined elsewhere) is nasty.  More
> importantly
>           you need to document how it affects the module's directives.
>           I'll +1 it when that's done.
>      wrowe: ditto's - good concept.
>
> Here's a patch to eliminate the "13", and to improve portability to
> EBCDIC machines by using apr_toupper().

Thanks for this - the fooness really needed to be sorted out before it was
rolled out over the other authn mechanisms.

We have used the exposed extra columns to support autologin to bugzilla,
amongst other things. The next plan is to update the docs to better
explain how these work.

Regards,
Graham
--



Mime
View raw message