httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <>
Subject [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
Date Fri, 31 Aug 2007 10:41:36 GMT
From the 2.2.x STATUS doc:
   * mod_authn_dbd: Export any additional columns queried in the SQL select
     into the environment with the name AUTHENTICATE_<COLUMN>. This brings
     mod_authn_dbd behaviour in line with mod_authnz_ldap.
     +1: minfrin
     niq: This wants a little tidying.  Use of 13 as a magic number (for a
          strlen of something defined elsewhere) is nasty.  More importantly
          you need to document how it affects the module's directives.
          I'll +1 it when that's done.
     wrowe: ditto's - good concept.

Here's a patch to eliminate the "13", and to improve portability to
EBCDIC machines by using apr_toupper().

<>        |     Fujitsu Siemens | 81730  Munich,  Germany

View raw message