Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Message-ID: <469C9B9E.5040709@apache.org>
Date: Tue, 17 Jul 2007 12:36:14 +0200
From: Mladen Turk <mturk@apache.org>
User-Agent: Mozilla
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r556860 - /httpd/httpd/branches/2.2.x/STATUS
References: <20070717092333.195091A981A@eris.apache.org>
 <469C97AB.7080901@rowe-clan.net>
In-Reply-To: <469C97AB.7080901@rowe-clan.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

William A. Rowe, Jr. wrote:
> mturk@apache.org wrote:
>> Author: mturk
>> Date: Tue Jul 17 02:23:30 2007
>> New Revision: 556860
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=556860
>> Log:
>> Comment the backport concerns for ApacheMonitor
>>
>> --- httpd/httpd/branches/2.2.x/STATUS (original)
>> +++ httpd/httpd/branches/2.2.x/STATUS Tue Jul 17 02:23:30 2007
>> @@ -113,6 +113,9 @@
>>        wrowe notes post today to list, can we please test for >= VISTA
>>        so this doesn't break again upon the release of longhorn server
>>        or 'nextgen' windows?
>> +      mturk notes: No, because we cannot be sure that any further version
>> +      will not break either the service or GUI api, in which case we
>> +      would need a separate code depending on the post VISTA versions.
> 
> But this is *nonsense*.  We may as well simply have APR stop working at each
> new version, if you are that worried about application compatibility.
>

Right. I didn't probably express myself clear enough.
We need a detection for VISTA, but this shouldn't break the functionality
if we have a VISTA+

You are right, the GetSystemOSVersion should always return TRUE if
dwPlatformId == VER_PLATFORM_WIN32_NT

I'll propose additional patch to the existing one and update the status:

Index: ApacheMonitor.c
===================================================================
--- ApacheMonitor.c	(revision 556830)
+++ ApacheMonitor.c	(working copy)
@@ -292,9 +292,6 @@
          else if (osvi.dwMajorVersion == 6) {
              *dwVersion = OS_VERSION_VISTA;
          }
-        else {
-            return FALSE;
-        }
          break;

      case VER_PLATFORM_WIN32_WINDOWS:


Regards,
Mladen.