Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 27426 invoked from network); 12 Jul 2007 08:49:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Jul 2007 08:49:14 -0000 Received: (qmail 37653 invoked by uid 500); 12 Jul 2007 08:49:11 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 37336 invoked by uid 500); 12 Jul 2007 08:49:10 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 37314 invoked by uid 99); 12 Jul 2007 08:49:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jul 2007 01:49:10 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jul 2007 01:49:06 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6C8mjH7012482; Thu, 12 Jul 2007 04:48:45 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6C8mifI010293; Thu, 12 Jul 2007 04:48:44 -0400 Received: from localhost ([127.0.0.1] helo=radish.cambridge.redhat.com) by radish.cambridge.redhat.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.62) (envelope-from ) id 1I8uLs-00047C-9T; Thu, 12 Jul 2007 09:48:44 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.8/8.13.8/Submit) id l6C8mhl1015821; Thu, 12 Jul 2007 09:48:43 +0100 Date: Thu, 12 Jul 2007 09:48:43 +0100 From: Joe Orton To: dev@httpd.apache.org Cc: cvs@httpd.apache.org Subject: Re: svn commit: r555458 - in /httpd/httpd/trunk: configure.in modules/ssl/config.m4 Message-ID: <20070712084843.GA15644@redhat.com> Mail-Followup-To: dev@httpd.apache.org, cvs@httpd.apache.org References: <20070712020602.691111A981A@eris.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20070712020602.691111A981A@eris.apache.org> User-Agent: Mutt/1.4.2.1i Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Jul 12, 2007 at 02:06:02AM -0000, Paul Querna wrote: > Author: pquerna > Date: Wed Jul 11 19:06:01 2007 > New Revision: 555458 > > URL: http://svn.apache.org/viewvc?view=rev&rev=555458 > Log: > Fix VPATH builds of httpd with the apr_memcache backend for ssl > sessions, when APR and APR-Util are also in a VPATH. This is caused > by APR_INCLUDEDIR actually having multiple paths in a VPATH builds, so > we need to use _INCLUDES instead. INCLUDES already includes (ahem) the `ap*-config --includes` output, likely all that is needed here is to do save_cpp=$CPPFLAGS CPPFLAGS="$CPPFLAGS $INCLUDES" (I have never understood why INCLUDES/CPPFLAGS are kept separate in the apr/httpd build system, it is a complete pain.) joe