httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r559837 - /httpd/httpd/trunk/modules/filters/mod_filter.c
Date Thu, 26 Jul 2007 19:46:24 GMT


On 07/26/2007 04:48 PM, niq@apache.org wrote:
> Author: niq
> Date: Thu Jul 26 07:48:48 2007
> New Revision: 559837
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=559837
> Log:
> Fix integer comparisons in mod_filter
> PR: 41835
> 
> Modified:
>     httpd/httpd/trunk/modules/filters/mod_filter.c
> 
> Modified: httpd/httpd/trunk/modules/filters/mod_filter.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_filter.c?view=diff&rev=559837&r1=559836&r2=559837
> ==============================================================================

> @@ -219,9 +225,12 @@
>                  }
>                  break;
>              case REGEX_MATCH:
> -                if (ap_regexec(provider->match.regex, str, 0, NULL, 0)
> -                    == AP_REG_NOMATCH) {
> -                match = 0;
> +                if (!provider->match.string) {

This is correct (because provider->match is a union and provider->match.string and
provider->match.regex are the same thing), but confusing. I would prefer
checking provider->match.regex instead.

Regards

RĂ¼diger


Mime
View raw message