Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <20070601141930.GA24876@infiltrator.gizzard.com>
References: <200705302209.l4UM9EdY012898@devsys.jaguNET.com>
 <DA1D5F7A-142F-49CA-BBA8-277422ECEC72@apache.org>
 <B19F6D6B-3CF9-4C7B-AE9F-F88C35854171@jaguNET.com>
 <20070601141930.GA24876@infiltrator.gizzard.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <60C08DB3-CFFB-45E0-A5F5-A0106CCC0A9F@jaguNET.com>
Content-Transfer-Encoding: 7bit
From: Jim Jagielski <jim@jaguNET.com>
Subject: Re: [Fwd: Apache httpd vulenrabilities]
Date: Fri, 1 Jun 2007 10:50:09 -0400
To: dev@httpd.apache.org


On Jun 1, 2007, at 10:19 AM, Colm MacCarthaigh wrote:

> On Fri, Jun 01, 2007 at 10:05:26AM -0400, Jim Jagielski wrote:
>> -	if (ap_scoreboard_image->servers[n].status != SERVER_DEAD &&
>> -		kill((pid = ap_scoreboard_image->parent[n].pid), 0) == -1) {
>> -	    ap_update_child_status(n, SERVER_DEAD, NULL);
>> -	    /* just mark it as having a successful exit status */
>> -	    bzero((char *) status, sizeof(ap_wait_t));
>> -	    return(pid);
>> -	}
>> +        pid = ap_scoreboard_image->parent[n].pid;
>> +        if (ap_scoreboard_image->servers[n].status != SERVER_DEAD) {
>> +            if (in_pid_table(pid)) {
>> +                if (kill(pid, 0) == -1) {
>> +                    ap_update_child_status(n, SERVER_DEAD, NULL);
>> +                    /* just mark it as having a successful exit
>> status */
>> +                    bzero((char *) status, sizeof(ap_wait_t));
>> +                    return(pid);
>> +                }
>
> Should we get rid of it from the table here? Can we get away without
> removing stale pids in general? What if they are recycled by the OS
> for something else?
>

No, that's a good point. We should likely remove the
pid from our table once the child goes away.