Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 93397 invoked from network); 2 Jun 2007 07:57:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Jun 2007 07:57:37 -0000 Received: (qmail 36618 invoked by uid 500); 2 Jun 2007 07:57:35 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 36560 invoked by uid 500); 2 Jun 2007 07:57:34 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 36549 invoked by uid 99); 2 Jun 2007 07:57:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jun 2007 00:57:34 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 02 Jun 2007 00:57:29 -0700 Received: (qmail 93291 invoked by uid 2161); 2 Jun 2007 07:57:09 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 41B261721C for ; Sat, 2 Jun 2007 09:56:58 +0200 (CEST) Message-ID: <466122CD.9050809@apache.org> Date: Sat, 02 Jun 2007 09:57:01 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: de, en, de-de, en-gb, cy, zu, xh MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r543667 - /httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c References: <20070601234437.C02B21A981A@eris.apache.org> In-Reply-To: <20070601234437.C02B21A981A@eris.apache.org> X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 06/02/2007 01:44 AM, jim@apache.org wrote: > Author: jim > Date: Fri Jun 1 16:44:36 2007 > New Revision: 543667 > > URL: http://svn.apache.org/viewvc?view=rev&rev=543667 > Log: > Minor nit... be consistent and unset even now :) > > Modified: > httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c > > Modified: httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c > URL: http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c?view=diff&rev=543667&r1=543666&r2=543667 > ============================================================================== > --- httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c (original) > +++ httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c Fri Jun 1 16:44:36 2007 > @@ -337,6 +337,7 @@ > pid = ap_scoreboard_image->parent[n].pid; > if (ap_in_pid_table(pid)) { > kill(pid, is_graceful ? SIGHUP : SIGTERM); > + ap_unset_pid_table(pid); Good catch. But is this also correct in the graceful / SIGHUP case? Couldn't it happen that we want to sent a SIGTERM later? Regards Rüdiger