Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: Re: ProxyTimeout does not work as documented
Date: Mon, 18 Jun 2007 13:57:38 +0200
Message-ID: 
 <3B21A253728EA247A10A692547A271538DCBAA@EITO-MBX03.internal.vodafone.com>
In-Reply-To: <1182161150.3921.7.camel@localhost.localdomain>
Thread-Topic: Re: ProxyTimeout does not work as documented
Thread-Index: AcexkCasig9iSxrRSyS5llYlgnboZwADdsKA
From: =?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VF-Group?=
 <ruediger.pluem@vodafone.com>
To: <dev@httpd.apache.org>


> -----Urspr=FCngliche Nachricht-----
> Von: Jean-Frederic =20
> Gesendet: Montag, 18. Juni 2007 12:06
> An: dev@httpd.apache.org
> Betreff: Re: ProxyTimeout does not work as documented
>=20
>=20
> On Sat, 2007-06-16 at 17:40 +0200, Ruediger Pluem wrote:
> >=20
> >=20
> > Digging somewhat deeper to actually do this I found the following
> > obstacle (hopefully I am wrong):
> >=20
> > 1. The right place to fix this is in ap_proxy_connect_backend
> >   (around line 2215 in proxy_util.c).
>=20
> The Timeout is the Default value already See =20
> c->base_server->timeout in
> core_pre_connection().=20

This happens afterwards in ap_proxy_connection_create and not for =
mod_proxy_ajp as
mod_proxy_ajp does not call ap_proxy_connection_create. This was fixed =
by
your patch in r546128.

>=20
> >=20
> > 2. We do not have a proxy_server_conf parameter in=20
> ap_proxy_connect_backend
> >    like in ap_proxy_connect_to_backend.
> >=20
> > 3. ap_proxy_connect_backend is part of a public API (mod_proxy.h).
> >=20
> > 4. Fixing the prototype of ap_proxy_connect_backend to add=20
> a proxy_server_conf
> >    parameter thus requires a major bump. Thus this would=20
> not be backportable :-(.
> >=20
> > I am not quite sure if we can do
> >=20
> >     void *sconf =3D s->module_config;
> >     proxy_server_conf *conf =3D (proxy_server_conf *)
> >         ap_get_module_config(sconf, &proxy_module);
>=20
> See modules/proxy/mod_proxy_balancer.c

Thanks for the pointer, but I stick to my opinion that this is ugly
there. But possibly we can go for the ugly way in 2.2.x and for the
API change in trunk.

>=20
> BTW: ping is not documented in the 2.2 doc, why?
>=20

Nobody backported the docs so far ;-). Seriously, currently I see no
other reason than this.


Regards

R=FCdiger