Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: domain of jfclere@gmail.com designates
 66.249.82.225 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:subject:from:to:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding;
        b=mkaJ3xAsmITsvr6Qk/dHQEbD9D6bt98CjmNwWlTaL9IARh4SqqfVWcTYsLNHHpgrKACUpzc7BVmXfWyJHN8MI26lRDWc9Ro98zgjmKoRV12WFuCDRHqTfgCTejMT3nfrOiupUjP8/FUAZ2AN9TlPv4oE57lWH2SbyFWImepx3MI=
Subject: Re: ProxyTimeout does not work as documented
From: Jean-Frederic <jfclere@gmail.com>
To: dev@httpd.apache.org
In-Reply-To: <82B39762-F317-41C0-B9DA-3F361E054743@jaguNET.com>
References: <464E2189.7060608@apache.org>
	 <1404e5910705190707s436bcf0ct51a739622dbbddbc@mail.gmail.com>
	 <464F4E80.9020202@apache.org>
	 <139A1F2D-5255-46F2-B42F-981944BE7C53@jaguNET.com>
	 <46520F6B.1090308@apache.org>
	 <82B39762-F317-41C0-B9DA-3F361E054743@jaguNET.com>
Content-Type: text/plain
Date: Fri, 08 Jun 2007 13:16:23 +0200
Message-Id: <1181301383.3806.20.camel@jfcpc>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2007-05-22 at 10:07 -0400, Jim Jagielski wrote:
> On May 21, 2007, at 5:30 PM, Ruediger Pluem wrote:
> 
> >
> >
> > On 05/21/2007 02:44 PM, Jim Jagielski wrote:
> >
> >> The logic should be:
> >>
> >>    1. If a per-worker value is set, use that.
> >>    2. If not, then if a ProxyTimeout value is set, use that.
> >>    3. Otherwise, use Timeout
> >>
> >> +1 on fixing that :)
> >
> > This sounds sane and I plan to do this, but what about the original  
> > question?
> > Do I get you right that you propose to adjust the documentation for  
> > ProxyTimeout?
> > The current behaviour of ProxyTimeout is to fall back to Timeout if  
> > no ProxyTimeout
> > is set. The documented behaviour is to have a default value of 300  
> > secs if there
> > is no ProxyTimeout set (regardless of the setting of Timeout, which  
> > also defaults
> > to 300).
> >
> 
> I think that the above logic makes the most sense and that
> the code and the docs should be adjusted to match the
> logic :) :)

The timeout is set to c->base_server->timeout in core_pre_connection()
called by ap_proxy_connection_create via  ap_run_pre_connection.
Quick patch is apr_socket_timeout_get() before ap_run_pre_connection and
apr_socket_timeout_set() after if needed.

Comments?

Cheers

Jean-Frederic

>