httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r543667 - /httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/mpmt_os2.c
Date Sat, 02 Jun 2007 21:29:31 GMT


On 06/02/2007 03:07 PM, Jim Jagielski wrote:
> 
> On Jun 2, 2007, at 3:57 AM, Ruediger Pluem wrote:
> 
>>
>>
>> On 06/02/2007 01:44 AM, jim@apache.org wrote:
>>
>>> Author: jim
>>> Date: Fri Jun  1 16:44:36 2007
>>> New Revision: 543667
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=543667
>>> Log:
>>> Minor nit... be consistent and unset even now :)
>>>
>>> Modified:
>>>     httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/ mpmt_os2.c
>>>
>>> Modified: httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/
>>> mpmt_os2.c
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-pid-
>>> table/server/mpm/mpmt_os2/mpmt_os2.c?
>>> view=diff&rev=543667&r1=543666&r2=543667
>>> =====================================================================
>>> =========
>>> --- httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/
>>> mpmt_os2.c (original)
>>> +++ httpd/httpd/branches/httpd-pid-table/server/mpm/mpmt_os2/
>>> mpmt_os2.c Fri Jun  1 16:44:36 2007
>>> @@ -337,6 +337,7 @@
>>>          pid = ap_scoreboard_image->parent[n].pid;
>>>          if (ap_in_pid_table(pid)) {
>>>              kill(pid, is_graceful ? SIGHUP : SIGTERM);
>>> +            ap_unset_pid_table(pid);
>>
>>
>> Good catch. But is this also correct in the graceful / SIGHUP case?
>> Couldn't it happen that we want to sent a SIGTERM later?
>>
> 
> Could be... It's been a LONG time since I looked at this
> MPM :)
> 

BTW: Do we have any OS/2 platform maintainer(s) still around?
If not there may arise the need for us to dump it if there is nobody around
who can maintain it.

Regards

RĂ¼diger


Mime
View raw message