httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r550519 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy.html.en docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c
Date Fri, 29 Jun 2007 09:35:53 GMT
On Mon, Jun 25, 2007 at 02:42:26PM -0000, Jean-Frederic Clere wrote:
> Author: jfclere
> Date: Mon Jun 25 07:42:25 2007
> New Revision: 550519
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=550519
> Log:
> Add sticky_path to solve PR41897.
...
>      if (!strcasecmp(key, "stickysession")) {
> +        char *path;
>          /* Balancer sticky session name.
>           * Set to something like JSESSIONID or
>           * PHPSESSIONID, etc..,
>           */
> -        balancer->sticky = apr_pstrdup(p, val);
> +        balancer->sticky = balancer->sticky_path = apr_pstrdup(p, val);
> +        if ((path = strchr(balancer->sticky, '|'))) {
> +            *path++ = '\0';
> +            balancer->sticky_path = path;

This breaks the const-preserving strchr in AP_DEBUG builds: 
balancer->sticky is const so path must be const too.

mod_proxy.c: In function 'set_balancer_param':
mod_proxy.c:284: warning: passing argument 1 of 'ap_strchr' discards qualifiers from pointer
target type


Mime
View raw message