httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [Fwd: Apache httpd vulenrabilities]
Date Fri, 01 Jun 2007 14:45:31 GMT
On Fri, Jun 01, 2007 at 10:50:09AM -0400, Jim Jagielski wrote:
> >Should we get rid of it from the table here? Can we get away without
> >removing stale pids in general? What if they are recycled by the OS
> >for something else?
> >
> 
> No, that's a good point. We should likely remove the
> pid from our table once the child goes away.

I think we need to do it with an actual table unset call too, not just
set the entry to "0" or whatever, so that we don't exhaust our table. 

On that point, instead of initialising with ap_make_table(pglobal, 100)
, it should probably use HARD_SERVER_LIMIT (if that's not in scope, it
may even justify making it in scope) instead of 100 too, to avoid
potential immediate exhaustion. 

Nice simple fix though, using a simple table seems like a way better
approach than trying to replicate a paralell scoreboard.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message