Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: local policy)
User-Agent: Microsoft-Entourage/11.3.3.061214
Date: Tue, 01 May 2007 11:27:32 -0400
Subject: Re: [PATCH] mod_wombat: add table_get and table_set
From: "Akins, Brian" <Brian.Akins@turner.com>
To: "dev@httpd.apache.org" <dev@httpd.apache.org>
Message-ID: <C25CD4A4.34FA4%Brian.Akins@turner.com>
Thread-Topic: [PATCH] mod_wombat: add table_get and table_set
Thread-Index: AceMBTxvezxw3vf4EduHiQAX8tAlJw==
In-Reply-To: <EC819537-4D70-4818-A2CC-EC1CF2F4CAC8@apache.org>
Mime-version: 1.0
Content-type: text/plain;
	charset="US-ASCII"
Content-transfer-encoding: 7bit

On 4/30/07 5:53 PM, "Brian McCallister" <brianm@apache.org> wrote:

> I would like to maintain a function which is analogous to
> lua_pushstring() and lua_pushinteger() for pushing the request_rec
> into a function call or whatnot from the C side.
> 
> Will this work with the hook? (I am a hook newb).

Sure.  The way I have it now, it calls the push function first in the hook.
We could move that outside the hook and still have the hook available.

> Even though these are static, we might want to be careful in naming
> as these are reaching into lua's namespace (lua_* and luaL_*).

Sure, we can rename these to apr_lua_table_methods and prefix the methods
with "apr_".
 
> Why pass the pool in (other than matching the hook form, but this
> isn't invoked via )

I added thepool because I'm sure at some point I will need it and didn't
want to rewrite anything that already called it.  I know not a good
reason...

-- 
Brian Akins
Chief Operations Engineer
Turner Digital Media Technologies