Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 86906 invoked from network); 7 May 2007 15:56:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 May 2007 15:56:36 -0000 Received: (qmail 75355 invoked by uid 500); 7 May 2007 15:56:39 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 75054 invoked by uid 500); 7 May 2007 15:56:38 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 75033 invoked by uid 99); 7 May 2007 15:56:38 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2007 08:56:38 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [207.113.241.148] (HELO iss04.interliant.com) (207.113.241.148) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2007 08:56:30 -0700 Received: from EX-009.mail.navisite.com (ex-009.interliant.com [207.113.240.184]) by iss04.interliant.com (8.10.2/8.10.2) with ESMTP id l47Fu9508643 for ; Mon, 7 May 2007 10:56:09 -0500 (CDT) Received: from [192.168.0.168] ([89.164.36.6]) by EX-009.mail.navisite.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 7 May 2007 10:56:06 -0500 Message-ID: <463F4C17.1030304@apache.org> Date: Mon, 07 May 2007 17:56:07 +0200 From: Mladen Turk User-Agent: Mozilla MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer References: <3B21A253728EA247A10A692547A271538DCAD0@EITO-MBX03.internal.vodafone.com> <4613B96B.602@apache.org> <4613C56C.7080305@2scale.de> <9D8FFB5C-F23B-4104-A687-4034ACA2E734@jaguNET.com> <46162B49.80703@2scale.de> <463F1BA4.2060707@apache.org> In-Reply-To: <463F1BA4.2060707@apache.org> Content-Type: multipart/mixed; boundary="------------010204050505030305010306" X-OriginalArrivalTime: 07 May 2007 15:56:06.0998 (UTC) FILETIME=[3921B760:01C790C0] X-Virus-Checked: Checked by ClamAV on apache.org This is a multi-part message in MIME format. --------------010204050505030305010306 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Ruediger Pluem wrote: > > On 04/06/2007 01:13 PM, Georg von Zezschwitz wrote: >> Jim Jagielski wrote: >> >> >> attached is the patch for trunk with documentation & Co. >> >> Could anybody review it & commit? > > Many thanks for sending the patch and my apologies that reviewing it took > that long. Please find my comments below. > I think we could use a simple two use case situation. To be able to backport that to the 2.2 branch I propose a following patch. It adds additional struct member sticky_path that is set to the sticky so if someone has in the config ... stickysession=JSESSIONID ... both sticky and sticky_path will be the same. However if there is a stickysession with ... stickysession=JSESSIONID|;jsessionid ... will make w->sticky=JSESSIONID and w->sticky_path=;jsessionid I'm not aware of any other way without introducing additional directives that could be backported to 2.2 The question is, is that backportable as well? If it is, I'll put that for a vote in STATUS. Regards, Mladen. --------------010204050505030305010306 Content-Type: application/octet-string; name="sticky_session.patch.txt" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="sticky_session.patch.txt" SW5kZXg6IG1vZF9wcm94eS5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gbW9kX3Byb3h5LmMJKHJl dmlzaW9uIDUzNTU3OSkNCisrKyBtb2RfcHJveHkuYwkod29ya2luZyBjb3B5KQ0KQEAgLTI3 NCwxMSArMjc0LDE4IEBADQogDQogICAgIGludCBpdmFsOw0KICAgICBpZiAoIXN0cmNhc2Vj bXAoa2V5LCAic3RpY2t5c2Vzc2lvbiIpKSB7DQorICAgICAgICBjaGFyICpwYXRoOw0KICAg ICAgICAgLyogQmFsYW5jZXIgc3RpY2t5IHNlc3Npb24gbmFtZS4NCiAgICAgICAgICAqIFNl dCB0byBzb21ldGhpbmcgbGlrZSBKU0VTU0lPTklEIG9yDQogICAgICAgICAgKiBQSFBTRVNT SU9OSUQsIGV0Yy4uLA0KICAgICAgICAgICovDQotICAgICAgICBiYWxhbmNlci0+c3RpY2t5 ID0gYXByX3BzdHJkdXAocCwgdmFsKTsNCisgICAgICAgIGJhbGFuY2VyLT5zdGlja3kgPSBi YWxhbmNlci0+c3RpY2t5X3BhdGggPSBhcHJfcHN0cmR1cChwLCB2YWwpOw0KKyAgICAgICAg aWYgKChwYXRoID0gc3RyY2hyKGJhbGFuY2VyLT5zdGlja3ksICd8JykpKSB7DQorICAgICAg ICAgICAgKnBhdGgrKyA9ICdcMCc7DQorICAgICAgICAgICAgYmFsYW5jZXItPnN0aWNreV9w YXRoID0gcGF0aDsNCisgICAgICAgIH0NCisgICAgICAgIGVsc2UNCisgICAgICAgICAgICBi YWxhbmNlci0+c3RpY2t5X3BhdGggPSBiYWxhbmNlci0+c3RpY2t5Ow0KICAgICB9DQogICAg IGVsc2UgaWYgKCFzdHJjYXNlY21wKGtleSwgIm5vZmFpbG92ZXIiKSkgew0KICAgICAgICAg LyogSWYgc2V0IHRvICdvbicgdGhlIHNlc3Npb24gd2lsbCBicmVhaw0KSW5kZXg6IG1vZF9w cm94eS5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09DQotLS0gbW9kX3Byb3h5LmgJKHJldmlzaW9uIDUzNTU3 OSkNCisrKyBtb2RfcHJveHkuaAkod29ya2luZyBjb3B5KQ0KQEAgLTM1NCw2ICszNTQsNyBA QA0KICAgICBhcHJfdGhyZWFkX211dGV4X3QgICptdXRleDsgIC8qIFRocmVhZCBsb2NrIGZv ciB1cGRhdGluZyBsYiBwYXJhbXMgKi8NCiAjZW5kaWYNCiAgICAgdm9pZCAgICAgICAgICAg ICpjb250ZXh0OyAgIC8qIGdlbmVyYWwgcHVycG9zZSBzdG9yYWdlICovDQorICAgIGNvbnN0 IGNoYXIgICAgICAqc3RpY2t5X3BhdGg7ICAvKiBVUkwgc3RpY2t5IHNlc3Npb24gaWRlbnRp ZmllciAqLw0KIH07DQogDQogc3RydWN0IHByb3h5X2JhbGFuY2VyX21ldGhvZCB7DQpJbmRl eDogbW9kX3Byb3h5X2JhbGFuY2VyLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBtb2RfcHJveHlf YmFsYW5jZXIuYwkocmV2aXNpb24gNTM1NTc5KQ0KKysrIG1vZF9wcm94eV9iYWxhbmNlci5j CSh3b3JraW5nIGNvcHkpDQpAQCAtMjQxLDEyICsyNDEsMTkgQEANCiAgICAgaWYgKCFiYWxh bmNlci0+c3RpY2t5KQ0KICAgICAgICAgcmV0dXJuIE5VTEw7DQogICAgIC8qIFRyeSB0byBm aW5kIHRoZSBzdGlja3kgcm91dGUgaW5zaWRlIHVybCAqLw0KLSAgICAqcm91dGUgPSBnZXRf cGF0aF9wYXJhbShyLT5wb29sLCAqdXJsLCBiYWxhbmNlci0+c3RpY2t5KTsNCi0gICAgaWYg KCEqcm91dGUpDQorICAgICpyb3V0ZSA9IGdldF9wYXRoX3BhcmFtKHItPnBvb2wsICp1cmws IGJhbGFuY2VyLT5zdGlja3lfcGF0aCk7DQorICAgIGlmICgqcm91dGUpIHsNCisgICAgICAg IGFwX2xvZ19lcnJvcihBUExPR19NQVJLLCBBUExPR19ERUJVRywgMCwgci0+c2VydmVyLA0K KyAgICAgICAgICAgICAgICAgICAgICJwcm94eTogQkFMQU5DRVI6IEZvdW5kIHZhbHVlICVz IGZvciAiDQorICAgICAgICAgICAgICAgICAgICAgInN0aWNreXNlc3Npb24gJXMiLCAqcm91 dGUsIGJhbGFuY2VyLT5zdGlja3lfcGF0aCk7DQorICAgIH0NCisgICAgZWxzZSB7DQogICAg ICAgICAqcm91dGUgPSBnZXRfY29va2llX3BhcmFtKHIsIGJhbGFuY2VyLT5zdGlja3kpOw0K LSAgICBhcF9sb2dfZXJyb3IoQVBMT0dfTUFSSywgQVBMT0dfREVCVUcsIDAsIHItPnNlcnZl ciwNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgInByb3h5OiBCQUxBTkNFUjogRm91 bmQgdmFsdWUgJXMgZm9yICINCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgInN0aWNr eXNlc3Npb24gJXMiLCAqcm91dGUsIGJhbGFuY2VyLT5zdGlja3kpOw0KKyAgICAgICAgaWYg KCpyb3V0ZSkNCisgICAgICAgICAgICBhcF9sb2dfZXJyb3IoQVBMT0dfTUFSSywgQVBMT0df REVCVUcsIDAsIHItPnNlcnZlciwNCisgICAgICAgICAgICAgICAgICAgICAgICAgInByb3h5 OiBCQUxBTkNFUjogRm91bmQgdmFsdWUgJXMgZm9yICINCisgICAgICAgICAgICAgICAgICAg ICAgICAgInN0aWNreXNlc3Npb24gJXMiLCAqcm91dGUsIGJhbGFuY2VyLT5zdGlja3kpOw0K KyAgICB9DQogICAgIC8qDQogICAgICAqIElmIHdlIGZvdW5kIGEgdmFsdWUgZm9yIHN0aWNr c2Vzc2lvbiwgZmluZCB0aGUgZmlyc3QgJy4nIHdpdGhpbi4NCiAgICAgICogRXZlcnl0aGlu ZyBhZnRlciAnLicgKGlmIHByZXNlbnQpIGlzIG91ciByb3V0ZS4NCg== --------------010204050505030305010306--