httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Rectanus" <brect...@gmail.com>
Subject Re: ProxyTimeout does not work as documented
Date Mon, 21 May 2007 15:21:42 GMT
On 5/21/07, Jim Jagielski <jim@jagunet.com> wrote:
>
> On May 19, 2007, at 3:22 PM, Ruediger Pluem wrote:
>
> >
> >
> > On 05/19/2007 04:07 PM, Eric Covener wrote:
> >> On 5/18/07, Ruediger Pluem <rpluem@apache.org> wrote:
> >>
> >>> Currently ProxyTimeout does not work as documented as the default
> >>> value is not
> >>> 300 secs, but the Timeout setting of the server. The question to
> >>> me is
> >>> now:
> >>> What should be fixed?
> >>>
> >>> - Documentation (such that it matches the code)
> >>> - Code (such that it matches the documentation)
> >>
> >>
> >> Acting like a connection timeout only for me proxying HTTP on
> >> 2.2.4. I
> >> think I've read about similiar befuddlements on assorted PRs.
> >>
> >> It is raised a secondary issue here:
> >> http://issues.apache.org/bugzilla/show_bug.cgi?id=11540
> >
> > I know :-). This is the next issue I want to address once the issue
> > above is solved.
> > In 2.2.x / trunk ProxyTimeout is ignored almost completely (it is
> > only used for CONNECT).
> > Workers either use their own timeout set via the worker timeout
> > parameter or
> > they use the server timeout as default, if no worker timeout is
> > set. Although this (nearly)
> > works as documented I plan to change this to let the workers use
> > the ProxyTimeout setting
> > as a default value in the case that they do not have their own
> > timeout set via a parameter.
> > This sounds a lot more sane to me instead of using the server
> > timeout here as a default value.
> >
>
> The logic should be:
>
>     1. If a per-worker value is set, use that.
>     2. If not, then if a ProxyTimeout value is set, use that.
>     3. Otherwise, use Timeout
>
> +1 on fixing that :)
>

OK, I did something similar already.  I attached a 'diff' that really
is not valid ;)  I had a whole bunch of other changes in there and did
not have time to get a proper diff and just removed my extra stuff
that did not pertain to timeouts.

Basically, I created a ap_proxy_do_connect_backend as a replacement
for ap_proxy_connect_backend that adds a request_rec *r parameter and
put the timeout stuff in
ap_proxy_do_connect_backend.

I needed the request_rec in there for some other work I was doing so
it turned out to work nicely.  Read the large comment block in the
'diff' for an explanation.

Comments on the idea of this?

And again note that this is not a proper diff, but just some text to
give you an idea of what I have done.

thanks,
-B

Mime
View raw message