httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <>
Subject [PATCH] mod_cache: Don't follow NULL pointers.
Date Wed, 02 May 2007 08:45:55 GMT

We encountered the following bug: httpd segfaulted due to a client 
emitting "Cache-Control: max-age=216000, max-stale" which is a 
perfectly valid header.

The segfault is caused by the fact that ap_cache_liststr() sets the 
value pointer to NULL when there is no value, and this isn't checked 
at all in the cases when a value pointer is passed.

I think that this patch catches all those occurances.

I'm not proud of the solution for max-stale without value, but it 
should do the job...

In any case, this is a bug that should be fixed ASAP and queued for 
inclusion in httpd 2.2.5 since it segfaults your httpd even with valid 

  Niklas Edmundsson, Admin @ {acc,hpc2n}      |
  I am Yoda of Borg.  Assimilated you will be, hmmm?
View raw message