httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akins, Brian" <>
Subject Re: [PATCH] mod_wombat: add table_get and table_set
Date Tue, 01 May 2007 15:27:32 GMT
On 4/30/07 5:53 PM, "Brian McCallister" <> wrote:

> I would like to maintain a function which is analogous to
> lua_pushstring() and lua_pushinteger() for pushing the request_rec
> into a function call or whatnot from the C side.
> Will this work with the hook? (I am a hook newb).

Sure.  The way I have it now, it calls the push function first in the hook.
We could move that outside the hook and still have the hook available.

> Even though these are static, we might want to be careful in naming
> as these are reaching into lua's namespace (lua_* and luaL_*).

Sure, we can rename these to apr_lua_table_methods and prefix the methods
with "apr_".
> Why pass the pool in (other than matching the hook form, but this
> isn't invoked via )

I added thepool because I'm sure at some point I will need it and didn't
want to rewrite anything that already called it.  I know not a good

Brian Akins
Chief Operations Engineer
Turner Digital Media Technologies

View raw message