httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: Patch for implementing ap_document_root as a hook
Date Mon, 23 Apr 2007 12:53:32 GMT
Jakob Goldbach wrote:
> Hi,
> Attached is a patch which implements ap_document_root(r) as a hook.
> This way modules can set document_root on the fly. (think vhost_alias)
> AND get the right DOCUMENT_ROOT env. variable (as set by
> ap_add_common_vars(r)).
> The patch also changes ap_core_translate to use ap_document_root(r)
> instead of conf->ap_document_root.  This way, modules that just need
> to point to a different docroot won't have to implement a translate
> hook by appending r->uri til r->filename, but just rely on
> ap_document_root.

-1 on the face of things.  The map_to_storage hook was added to accomplish
what you desire.  Unfortunately it is not coupled to the DOCUMENT_ROOT
variable, but I'd look at remedying this over building on ap_document_root,
which should simply go away, IMHO.

View raw message