httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: ProxyErrorOverride and redirects (PR 39245)
Date Wed, 04 Apr 2007 15:30:31 GMT
On Wed, 4 Apr 2007 10:48:58 -0400
"Eric Covener" <covener@gmail.com> wrote:

> Can any proxy gurus reconsider this bug status?

Hmmm, I have some recollection of debating this before,
presumably without reaching any consensus for change.

> -            if (conf->error_override == 0 ||
> ap_is_HTTP_SUCCESS(r->status)) {
> +            if (conf->error_override == 0 ||
> ap_is_HTTP_SUCCESS(r->status) || ap_is_HTTP_REDIRECT(r->status)) {

I don't think we could accept that, because it breaks existing
behaviour someone might be relying on.

What I'd suggest is giving conf->error_override a numeric value
rather than an On/Off flag, and checking
r->status < conf->error_override
That way we'll get existing behaviour with it set to 300 (so we
can alias "On" to that), and get the behaviour you want with 400
(which could perhaps be given another alias).

Any objections to that?

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message