httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Covener" <cove...@gmail.com>
Subject Re: ProxyErrorOverride and redirects (PR 39245)
Date Wed, 04 Apr 2007 16:07:25 GMT
On 4/4/07, Nick Kew <nick@webthing.com> wrote:
> On Wed, 4 Apr 2007 10:48:58 -0400
> "Eric Covener" <covener@gmail.com> wrote:
>
> > Can any proxy gurus reconsider this bug status?
>
> Hmmm, I have some recollection of debating this before,
> presumably without reaching any consensus for change.
>
> > -            if (conf->error_override == 0 ||
> > ap_is_HTTP_SUCCESS(r->status)) {
> > +            if (conf->error_override == 0 ||
> > ap_is_HTTP_SUCCESS(r->status) || ap_is_HTTP_REDIRECT(r->status)) {

>
> I don't think we could accept that, because it breaks existing
> behaviour someone might be relying on.
>
> What I'd suggest is giving conf->error_override a numeric value
> rather than an On/Off flag, and checking
> r->status < conf->error_override
> That way we'll get existing behaviour with it set to 300 (so we
> can alias "On" to that), and get the behaviour you want with 400
> (which could perhaps be given another alias).
>
> Any objections to that?
>

Thanks Nick -- Looks reasonable, but flipping the comparison might
make more sense based on the structure of context:

# 2.2.4 behavior
# Alias for ProxyErrorOverride 300
ProxyErrorOverride on

# Only override 4xx/5xx
# Alias as "ERRORS" ?
ProxyErrorOverride 400

 if (conf->error_override == 0 ||
      ap_is_HTTP_SUCCESS(r->status) ||
      r->status >= conf->error_override) {
      // no override

-- 
Eric Covener
covener@gmail.com

Mime
View raw message