Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <45F5CE42.6060001@ptc.com>
Date: Mon, 12 Mar 2007 17:03:46 -0500
From: Andy Wang <awang@ptc.com>
User-Agent: Thunderbird 1.5.0.10 (X11/20070305)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: util_ldap.c use of hardcoded sizelimit on	ldap_search_ext_s
 causing
 error
References: <3ce0569d0702151202l7d7d8252m2d14ccdaf45bb489@mail.gmail.com>
 <cc67648e0702190829qc3a167evfb7e611fac2acfd4@mail.gmail.com>
 <45DABCBE.6720.00AC.0@novell.com>
 <3ce0569d0702220612n3750e50blf7a7d570a7a4c883@mail.gmail.com>
 <45DD5F4B.6720.00AC.0@novell.com>
In-Reply-To: <45DD5F4B.6720.00AC.0@novell.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Brad Nicholes wrote:
> Maybe I missed this before, but what platform or LDAP SDK does this fail on?  The Novell LDAP SDK obviously supports LDAP_DEFAULT_SIZELIMIT (-1) and according to the OpenLDAP source code, it also supports the same functionality if the value of sizelimit is -1 even though it does not specifically define LDAP_DEFAULT_SIZELIMIT.  I don't know what the Netscape or Microsoft SDKs support other than the fact that we have been passing those SDKs the same -1 value without a problem.  I believe that the only reason why we see the hardcoded -1 rather than a #define is simply because not all of the SDKs provide a #define yet they all seems to support the functionality.  We just need to validate that theory.
>
> Brad
>
>   
http://issues.apache.org/bugzilla/show_bug.cgi?id=37814
Microsoft's LDAP SDK has problems with -1.  The MS SDK uses an unsigned 
int, so we get 2^32-1 for the size limit which is out of spec per the 
RFC and openldap 2.2.x doesn't like it.

I've never checked to see if the MS LDAP SDK has a LDAP_NO_LIMIT or 
LDAP_DEFAULT_LIMIT define, so if it doesn't, perhaps someone wants to 
merge my patch in to this one.

Andy