httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r517238 - in /httpd/httpd/trunk: CHANGES modules/http/http_etag.c
Date Tue, 13 Mar 2007 11:59:04 GMT
On Mon, Mar 12, 2007 at 09:38:34PM +0100, Ruediger Pluem wrote:
> On 03/12/2007 04:05 PM, jorton@apache.org wrote:
...
> > + * (basically a faster version of 'sprintf("%llx")')
> >   */
> >  #define HEX_DIGITS "0123456789abcdef"
> > -static char *etag_ulong_to_hex(char *next, unsigned long u)
> > +static char *etag_uint64_to_hex(char *next, apr_uint64_t u)
> >  {
> >      int printing = 0;
> >      int shift = sizeof(unsigned long) * 8 - 4;
> 
> Shouldn't this be
> 
> int shift = sizeof(apr_uint64_t) * 8 - 4;
> 
> instead of the above?

It should indeed!  Good catch, thanks - fixed in r517654.

joe

Mime
View raw message