Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 7457 invoked from network); 14 Jan 2007 17:55:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Jan 2007 17:55:21 -0000 Received: (qmail 7320 invoked by uid 500); 14 Jan 2007 17:55:21 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 7271 invoked by uid 500); 14 Jan 2007 17:55:20 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 7260 invoked by uid 99); 14 Jan 2007 17:55:20 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jan 2007 09:55:20 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [213.235.218.3] (HELO luxus.ask-us.at) (213.235.218.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jan 2007 09:55:11 -0800 Received: from [10.213.40.8] ([10.213.40.8]) by luxus.ask-us.at with Microsoft SMTPSVC(6.0.3790.1830); Sun, 14 Jan 2007 18:54:49 +0100 Message-ID: <45AA6E68.1010808@ask-us.at> Date: Sun, 14 Jan 2007 18:54:48 +0100 From: Bernard Buri User-Agent: Thunderbird 1.5.0.9 (X11/20061227) MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: Re: mod_mbox patches References: <45A3A71D.7000004@ask-us.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 14 Jan 2007 17:54:49.0035 (UTC) FILETIME=[158491B0:01C73805] X-Virus-Checked: Checked by ClamAV on apache.org Maxime Petazzoni wrote: > Hi, > > Le 9 janv. 07 � 15:30, Bernard Buri a �crit : > >> Here are some patches for mod_mbox to correcly display binary mime-parts. >> Please review; > > Ok, it's been long since I got the time to dive into mod_mbox's code and > I may be mistaking here, but isn't this change enough (and lighter?) : > > if (pdata != NULL) { > - ap_rputs(pdata, r); > + ap_rwrite(pdata, mime_part->body_len, r); > } > > Regards, > - Sam > --Maxime Petazzoni (http://www.bulix.org) > -- gone crazy, back soon. leave message. > > > This is true. So the full patch is: --- module-2.0/mod_mbox_out.c.orig Sun Jan 14 18:43:52 2007 +++ module-2.0/mod_mbox_out.c Sun Jan 14 18:44:55 2007 @@ -1036,7 +1036,7 @@ mime_part->body, mime_part->body_len); if (pdata != NULL) { - ap_rputs(pdata, r); + ap_rwrite(pdata, mime_part->body_len, r); } } Thank you;