Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <45A3318D.6060401@rowe-clan.net>
Date: Tue, 09 Jan 2007 00:09:17 -0600
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 1.5.0.8 (X11/20061107)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [VOTE] [CORRECTIONS] httpd-2.2.4 release candidate for review
References: <459F5295.6050108@rowe-clan.net>
 <7BDED619-7F5B-417B-8E3F-1B3A78C4A727@apache.org>
In-Reply-To: <7BDED619-7F5B-417B-8E3F-1B3A78C4A727@apache.org>
Content-Type: multipart/mixed;
 boundary="------------040204070507050507070605"

This is a multi-part message in MIME format.
--------------040204070507050507070605
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Before I go any further, httpd-2.2.4-win32-src.zip is updated here at 6am UT
and will take an hour to move across to the live site

  http://httpd.apache.org/dev/dist/

while the .tar files remain unchanged.  Feedback to several issues inline...


Sander Temme wrote on 01/07/07:
> 
> The RC has been running on people.apache.org as of 1:46PM today.

Rekicked a 48 hour release clock from that mark.  Afternoon the of the
9th I'll call the vote, it would be good to see a two-day update from
yourself, Joe or another infra-team member.


Gustavo Lopes wrote:
> Adding:
> $(MAKE) $(MAKEOPT) -f Makefile.win SHORT=$(SHORT) LONG=$(LONG) \
>  _copybin src_exe=exe.manifest src_dll=dll.manifest src_so=so.manifest
> quiet="-"  \
>  inst_exe="$(INSTDIR)\bin"                              \
>  inst_dll="$(INSTDIR)\bin"                              \
>  inst_so="$(INSTDIR)\modules"
> to the makefile automates the copy of the manifest files and resolves
> the problem.

FOR THIS VERSION ONLY, I will hack in this method, it's fast, efficient,
and quiet provided we first

if EXIST $(LONG)\httpd.exe.manifest \

before that command.  It's not elegant, but folks already know my opinion
of VC8, with its deprecated POSIX(?!?) and .manifest crapola for clib.  And
it gets folks building with no further changes.

Diff attached.  I will commit and svn cp Makefile.win to tags/2.2.4/, if devs
feel the historical documentation is worthwhile.  Patching trunk/ to truly
embed .manifest files where/when appropriate, instead.  If folks object, state
now before this goes live in 30 hours.  It really doesn't seem worthwhile to
toss 2.2.4 on this account for one platform.

Thank you Gustavo for the straight-line solution to this issue for VC8 users.


Jorge Schrauwen wrote:
> This is a wild guess but !IF EXIST("srclib\zlib")
> in the win-src packaged the zlib and openssl folders exist without the
> files being in there. I guess this broke it.

Yes - I tried an alternate method to package the .zip's - moving the .mak
and .dep files from win to linux.  I hadn't unhooked my symbolic junctions
and yes, there were .mak files hiding in srclib/zlib and srclib/openssl.
Good catch by Issac Goldstand.

My bad, fixed package inc with srclib/zlib/, srclib/openssl removed, and
the attached patch to Makefile.win applied to 'get VC8 users by' for now.

Bill


--------------040204070507050507070605
Content-Type: text/x-patch;
 name="hack-msvc8-httpd-2.2.4.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="hack-msvc8-httpd-2.2.4.patch"

--- Makefile.win.orig	2006-12-07 11:09:37.000000000 -0600
+++ Makefile.win	2007-01-08 23:55:56.000000000 -0600
@@ -605,6 +605,13 @@
 		inst_exe="$(INSTDIR)\bin"                              \
 		inst_dll="$(INSTDIR)\bin"                              \
 		inst_so="$(INSTDIR)\modules"
+	if EXIST $(LONG)\httpd.exe.manifest                              \
+	  $(MAKE) $(MAKEOPT) -f Makefile.win SHORT=$(SHORT) LONG=$(LONG) \
+		_copybin src_exe=exe.manifest src_dll=dll.manifest       \
+		src_so=so.manifest quiet="-"                             \
+		inst_exe="$(INSTDIR)\bin"                                \
+		inst_dll="$(INSTDIR)\bin"                                \
+		inst_so="$(INSTDIR)\modules"
 	cd srclib\apr-iconv
 	$(MAKE) $(MAKEOPT) -f build\modules.mk.win install \
 		BUILD_MODE=$(LONG) BIND_MODE=shared API_SOURCE=. \

--------------040204070507050507070605--