httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: Piped logger nightmares
Date Sat, 06 Jan 2007 14:55:42 GMT
On 1/5/07, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> http://svn.apache.org/viewvc?view=rev&sortby=date&revision=104019

Sanity check...  1.3 used /bin/sh in-between httpd and the piped logger.

4513  execve("/bin/sh", ["/bin/sh", "-c",
"/scratch/inst/13/bin/rotatelogs "...], [/* 36 vars */] <unfinished
...>

Why haven't these problems been seen there?  Is the problem really
triggered by some minor detail in the 2.x implementation which differs
from 1.3, and not simply by letting the shell assist with the startup?

> The reason given; "some examples use the shell..." wasn't enough to
> make this the default behavior against all installations, IMHO.

That plus the fact that 1.3 had the same behavior (at least at the
high level; maybe some smaller detail is wrong) with nobody
complaining...

Perhaps in pre APR days the 1.3 implementation on Windows differed
more greatly from Unix (e.g., shell wasn't even used on Windows)?  Or
perhaps it was busted on Windows there too but nobody cared?

> I'd suggest an alternate syntax; use |$ where a shell command is really
> actually demanded.  So...

That works for me, though it is an unexpected migration.

Possible mitigation of the migration issue:

* the '$' should be required in 2.0/2.2 on platform(s) where we know
the shell causes actual problems, and starting with 2.4 it should be
required everywhere

* shell used automatically with 2.0/2.2 if it is obvious that the
shell is needed (no path to the piped logger program, or shell
redirection used)

-/-

Can you confirm that 1.3 was busted on Windows too?

Mime
View raw message