httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giuliano Gavazzi <dev-apache....@humph.com>
Subject Re: mod_cache: save filter recalls body to non-empty brigade?
Date Wed, 24 Jan 2007 13:39:24 GMT

On 24 Jan 2007, at 13:15, Niklas Edmundsson wrote:

>
> In mod_cache, recall_body() is called in the cache_save_filter()  
> when revalidating an entity.
>
> However, if I have understood things correctly the brigade is  
> already populated when the save filter is called, so calling  
> recall_body() in this case would place additional stuff in the  
> bucket brigade.
>
> Wouldn't it be more correct to empty the brigade before calling  
> recall_body()? Or am I missing something?
>
> This is mod_cache in vanilla httpd 2.2.4 by the way.

this could be the underlying cause to a bug I reported against  
mod_cache+mod_include in 2.2.4 and then reported to this list:

http://issues.apache.org/bugzilla/show_bug.cgi?id=41362

and

http://www.mail-archive.com/dev@httpd.apache.org/msg35232.html

g

Mime
View raw message