httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernard Buri <be...@ask-us.at>
Subject Re: Re: mod_mbox patches
Date Sun, 14 Jan 2007 17:54:48 GMT
Maxime Petazzoni wrote:
> Hi,
> 
> Le 9 janv. 07 à 15:30, Bernard Buri a écrit :
> 
>> Here are some patches for mod_mbox to correcly display binary mime-parts.
>> Please review;
> 
> Ok, it's been long since I got the time to dive into mod_mbox's code and 
> I may be mistaking here, but isn't this change enough (and lighter?) :
> 
>          if (pdata != NULL) {
> -            ap_rputs(pdata, r);
> +            ap_rwrite(pdata, mime_part->body_len, r);
>          }
> 
> Regards,
> - Sam
> --Maxime Petazzoni (http://www.bulix.org)
> -- gone crazy, back soon. leave message.
> 
> 
> 

This is true. So the full patch is:
--- module-2.0/mod_mbox_out.c.orig      Sun Jan 14 18:43:52 2007
+++ module-2.0/mod_mbox_out.c   Sun Jan 14 18:44:55 2007
@@ -1036,7 +1036,7 @@
                                        mime_part->body,
                                        mime_part->body_len);
          if (pdata != NULL) {
-            ap_rputs(pdata, r);
+            ap_rwrite(pdata, mime_part->body_len, r);
          }
      }

Thank you;

Mime
View raw message