httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Erenkrantz" <jus...@erenkrantz.com>
Subject Re: svn commit: r462696 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h
Date Sun, 24 Dec 2006 19:46:11 GMT
On 10/18/06, Trent Nelson <tnelson@onresolve.com> wrote:
> > -----Original Message-----
> > From: minfrin@apache.org [mailto:minfrin@apache.org]
> > Sent: 11 October 2006 05:31
> > To: cvs@httpd.apache.org
> > Subject: svn commit: r462696 - in /httpd/httpd/trunk: CHANGES
> > modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h
> >
> > Author: minfrin
> > Date: Tue Oct 10 21:31:18 2006
> > New Revision: 462696
>
> > --- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
> > +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Oct 10
> 21:31:18
>
> > +APU_DECLARE_DATA const apr_bucket_type_t bucket_type_diskcache = {
> > +    "DISKCACHE", 5, APR_BUCKET_DATA,
> > +    diskcache_bucket_destroy,
> > +    diskcache_bucket_read,
> > +    diskcache_bucket_setaside,
> > +    apr_bucket_shared_split,
> > +    apr_bucket_shared_copy
> > +};
>
> This results in the following compilation error on Win32 (Visual Studio
> 2005):
>
> .\mod_disk_cache.c(251) : error C2491: 'bucket_type_diskcache' :
> definition of dllimport data not allowed

I have the same issue here - I locally removed the APU_DECLARE_DATA
line which I have no idea is the right thing or not.

This series of commits was vetoed way back when for other reasons, but
Graham has not yet reverted.  Since this busts the tree *and* has been
vetoed, if this is not reverted by Dec 29 (i.e. 5 days from now;
giving two extra days for the holidays), I will revert all of the
relevant commits in trunk then.

Thanks.  -- justin

Mime
View raw message