httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: archive.apache.org issues
Date Sat, 30 Dec 2006 11:11:23 GMT


On 12/30/2006 01:07 AM, Ruediger Pluem wrote:
> 
> On 12/29/2006 06:17 AM, Paul Querna wrote:
> 
> 
>>Ya, I'm not sure why that is happening either.
>>
>>This works:
>>http://archive.apache.org/dist/
>>
>>And so does this:
>>http://archive.apache.org/index.html
>>
>>But this:
>>http://archive.apache.org/
>>
>>Does not.  So, the error log has:
>>[Fri Dec 29 05:10:00 2006] [error] [client 66.225.25.189] (70008)Partial
>>results are valid but processing is incomplete: access to /index.html failed
>>
>>It seems like the cause must be something broken in httpd trunk.
>>
>>I think this commit did it:
>>http://svn.apache.org/viewvc?view=rev&revision=425394
> 
> 
> I think we should not shoot the messenger here :-):
> 
> --- httpd/httpd/trunk/server/request.c	2006/07/25 13:33:05	425393
> +++ httpd/httpd/trunk/server/request.c	2006/07/25 13:40:32	425394
> @@ -553,9 +553,22 @@
>               * check.
>               */
>              if (!(opts & OPT_SYM_LINKS)) {
> -                apr_stat(&thisinfo, r->filename,
> -                         APR_FINFO_MIN | APR_FINFO_NAME | APR_FINFO_LINK,
> -                         r->pool);
> +                rv = apr_stat(&thisinfo, r->filename,
> +                              APR_FINFO_MIN | APR_FINFO_NAME | APR_FINFO_LINK,

Digging somewhat deeper it turns out that adding APR_FINFO_NAME to the list of wanted
information causes this apr_stat to return always APR_INCOMPLETE on Unix platforms in
the case that the call to the native stat / lstat does not fail. This raises the
following questions:

1. Do we need to add APR_FINFO_NAME to this apr_stat call? I think we do not need it
   on Unix platforms but I am not sure if this is true for other platforms.

2. If we need it can we simply ignore an APR_INCOMPLETE return code on all platforms
   and only bail out if ((rv != APR_INCOMPLETE) && (rv != APR_SUCCESS))

Regards

RĂ¼diger



Mime
View raw message