From dev-return-55504-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org Wed Nov 15 20:33:55 2006 Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 25381 invoked from network); 15 Nov 2006 20:33:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Nov 2006 20:33:53 -0000 Received: (qmail 72770 invoked by uid 500); 15 Nov 2006 20:33:59 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 72710 invoked by uid 500); 15 Nov 2006 20:33:58 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 72699 invoked by uid 99); 15 Nov 2006 20:33:58 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2006 12:33:58 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Nov 2006 12:33:47 -0800 Received: (qmail 25266 invoked by uid 2161); 15 Nov 2006 20:33:27 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 5F6291721C for ; Wed, 15 Nov 2006 21:33:16 +0100 (CET) Message-ID: <455B7983.1030409@apache.org> Date: Wed, 15 Nov 2006 21:33:07 +0100 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: de, en, de-de, en-gb, cy, zu, xh MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: http://svn.apache.org/viewvc?view=rev&revision=426799 References: <20061115142423.6fd49f6d@grimnir> In-Reply-To: <20061115142423.6fd49f6d@grimnir> X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 11/15/2006 03:24 PM, Nick Kew wrote: > I've been trying to review the mod_deflate updates. Thanks for doing so. I really appreciate this. > > The deflate filter stuff looks good. But I'm confused by the > validation buffer usage in the input filter. You only allocate > a validation buffer at line 1177 (STREAM_END), yet you test > it at line 1134: presumably that'll only ever test positive > on a subsequent call. Shouldn't the block around 1134 be > brought to the top of the function, so it catches the case > of a last brigade containing only an EOS? No. If the last brigade does only contain an EOS bucket and the validation buffer is still incomplete it does mean that the validation data for the whole stream is incomplete. If we hit an EOS bucket all validation data must be available. Keep in mind that we process validation data for ourselves. We do not have to push this data through the inflate function and have it inflate to the ctx->buffer. We read it directly from the bucket. I hope this make things more clear. If not, please do not hesitate to ask me until I see an error or explained it clearly :-). Because of your question I had to rewalk the code path and I think I found two other bugs with my code. I fixed them on trunk: http://svn.apache.org/viewvc?view=rev&revision=475403 http://svn.apache.org/viewvc?view=rev&revision=475406 It would be nice if you could give me a short feedback on them. If you agree with them I would incorporate them in the backport proposal. Regards Rüdiger