httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject Re: [PATCHES] mod_disk_cache read-while-caching
Date Sun, 08 Oct 2006 17:35:47 GMT
On Thu, 5 Oct 2006, Niklas Edmundsson wrote:

> OK, here comes the latest two patches in the mod_disk_cache improvement 
> parody. I'll attach these patches to bug #39380, but with less comments.

I discovered a few misses, mostly not NULL:ing fd pointers when 
closing them, missing close/flush, and some unneccessary code 
duplication instead of calling the right helper in 
replace_brigade_with_cache().

The misses are in the loadstore-patch, so I would recommend applying 
this before reviewing the results even though it's generated from a 
file with the read-while-caching patch applied.

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Real men write self-modifying code
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Mime
View raw message