httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject Re: [PATCH] mod_disk_cache working LFS (filecopy)
Date Sun, 01 Oct 2006 08:40:31 GMT
On Sat, 30 Sep 2006, Davi Arnaut wrote:

> Hi,
>
> Wouldn't you avoid a lot of complexity in this patch
> if you just deleted from the brigade the implicitly
> created heap buckets while reading file buckets ?
>
> Something like:
>
> store_body:
> 	.. if (is_file_bucket(bucket))
> 		copy_file_bucket(bucket, bb);

Probably, but that doesn't allow for creating a thread/process that 
does the copying in the background, which is my long term goal.

Also, simply doing bucket_delete like that means that the file will 
never be sent to the client, which is a bad thing IMO ;)

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Excuse me, is that a toupee or do you have a tribble on your head
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Mime
View raw message