httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: [Fwd: Re: apr_brigade_create() produces a corrupt brigade]
Date Sun, 29 Oct 2006 15:12:32 GMT


On 10/29/2006 03:53 PM, Graham Leggett wrote:
> Ruediger Pluem wrote:
> 
>> Just two curious questions:
>>
>> 1. Did APR_BRIGADE_EMPTY return true on this newly created brigade?
> 
> 
> No idea, didn't try it.
> 
>> 2. Shouldn't the code take care never to process the sentinel because
>> of the
>>    problems you pointed out above (invalid data, especially in the
>> jump table)?
> 
> 
> Which code, apr or the client code?

Client code.

> 
> In the case of the client code, it shouldn't have to take care about
> anything - if an entry in the jump table is unimplemented for any
> reason, it should be initialised to NULL, and attempts to call those
> methods should return APR_ENOTIMPL.
> 
> At the moment, no clean error occurs, as the code falls of the rails and
> eventually crashes randomly later on.

This sounds reasonable. At least this produces reliable error situations in the
case you use the sentinel by error and make things much easier to debug.
Guess that needs to be fixed inside of apr-util.

Regards

RĂ¼diger


Mime
View raw message