httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r464141 - in /httpd/httpd/trunk/srclib/pcre: dftables.c dftables.dsp
Date Mon, 16 Oct 2006 17:04:11 GMT
William A. Rowe, Jr. wrote:
> Mladen Turk wrote:
>> William A. Rowe, Jr. wrote:
>>> why not s#/wd:4996#/D "_CRT_SECURE_NO_DEPRECATE"#
>>>
>> /wd with colon like (/wd:4966) gives:
>> Command line error D8021 : invalid numeric argument '/wd:4996'    cl
>> when converted to VS2005.
>> BTW according to the MSDN the proper format is /wdNNNN not /wd:NNNN
> 
> Yes - I understood that from your first commit message, thank you for this
> catch!
> 
>> Also the _CRT_SECURE_NO_DEPRECATE is not required.
> 
> Since you proposed that define as the alternative to /wd4996, I was curious
> why you preferred to disable the warning over defining out the warning?
> That's all - either way thank you for the fix.
> 

It was a simple copy/paste from apr.hw,
so that's why _CRT_SECURE_NO_DEPRECATE get into focus :)
VS2005 compiles the converted dftables.vcproj without warnings.

Regards,
Mladen.

Mime
View raw message