httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r462696 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h
Date Wed, 11 Oct 2006 10:43:15 GMT


On 10/11/2006 06:31 AM,  wrote:
> Author: minfrin
> Date: Tue Oct 10 21:31:18 2006
> New Revision: 462696
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=462696
> Log:
> mod_disk_cache: Implement read-while-caching.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/cache/mod_disk_cache.c
>     httpd/httpd/trunk/modules/cache/mod_disk_cache.h
> 

> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_disk_cache.h?view=diff&rev=462696&r1=462695&r2=462696
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.h (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.h Tue Oct 10 21:31:18 2006
> @@ -84,7 +84,8 @@
>  

> +
> +typedef struct diskcache_bucket_data diskcache_bucket_data;
> +struct diskcache_bucket_data {
> +    /* Number of buckets using this memory */
> +    apr_bucket_refcount  refcount;
> +    apr_file_t  *fd;
> +    /* The pool into which any needed structures should
> +     *  be created while reading from this file bucket */
> +    apr_pool_t *readpool;
> +    /* Cache update timeout */
> +    apr_interval_time_t updtimeout;
> +
> +};

This breaks the compilation of htcacheclean as apr_bucket_refcount is undefined there.
So we either need to include apr_buckets.h in htcacheclean.c or we need to include it
into mod_disk_cache.h. mod_disk_cache itself has no problem with this as apr_buckets.h
is already included via mod_cache.h. BTW: Have you checked if htcacheclean still works
with the new disk format?


Regards

RĂ¼diger


Mime
View raw message