httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Georgi Chorbadzhiyski ...@unixsol.org>
Subject [PATCH] Small fix for inconsistency in 1.3, 2.0 and 2.2 mod_status module
Date Sat, 07 Oct 2006 21:55:54 GMT
Hi guys,
today I've upgraded one of my servers from 1.3 to 2.2 and discovered a problem with
mod_status in newer versions. It is not a big problem, but it certainly is an inconsistency
between default and "notable mode" when extended status is set enabled.

I'm running mod_proxy as front end for video stream servers and using mod_status output
to check which connections are active.

Output from Apache 1.3.37 mod_status looks like this:
 /default mode/
   Srv  PID  Acc M CPU  SS Req Conn Child Slot        Client   VHost            Request
   37-0 5013 0/237/237   W  0.53 1 0 0.0 28.34 28.34  1.2.3.4  host.example.org GET /proxied/stream.avi
HTTP/1.1
 /notables mode/
   Server 0-0 (4965): 0|0|0 [Write] u0 s0 cu0 cs0 1 0 (0 B|0 B|0 B) 1.2.3.4 {GET /proxied/stream.avi
HTTP/1.1} [host.example.org]

Output from Apache 2.0.59 and 2.2.3 mod_status is looks like this:
 /default mode/
   Srv PID   Acc M CPU  SS  Req  Conn Child Slot Client  VHost  Request
   1-3 28181 0/0/0       R  0.00 78    0 0.0 0.00 0.00   ?      ?         ..reading..
 /notables mode/
   Server 1-3 (28181): 0|0|0 [Read] u0 s0 cu0 cs0 44 0 (0 B|0 B|0 B) 1.2.3.4 {GET /proxied/stream.avi
HTTP/1.1} [host.example.org]

Ignoring the fact that 1.3 shows connections in Write status and 2.x in Read status,
the problem is that connections in Read status are missing client, vhost and request
fields when shown as table.

Looking at the source of mod_status I see "...status == SERVER_BUSY_READ" check but
IMHO this check is bogus and can be removed, thus making "notable mode" and default
status output consistent.

Attached are patches for 1.3, 2.0.59 and 2.2.3 that remove the check responsible for
"...reading..." message.

If they're OK, please apply.

-- 
Georgi Chorbadzhiyski
http://georgi.unixsol.org/

Mime
View raw message