httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Graham Leggett" <minf...@sharp.fm>
Subject Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mod_mem_cache.c
Date Fri, 27 Oct 2006 16:09:20 GMT
On Fri, October 27, 2006 6:05 pm, Niklas Edmundsson wrote:

> The purpose of that code was originally to make "EnableSendfile Off"
> in the config file work. APR_HAS_SENDFILE only tells you that APR has
> sendfile.

It still does that as far as I can see:

#if APR_HAS_SENDFILE
    core_dir_config *pdconf = ap_get_module_config(r->per_dir_config,
                                                   &core_module);
#endif

    flags = APR_READ|APR_BINARY|APR_BUFFERED;
#if APR_HAS_SENDFILE
    flags |= ((pdconf->enable_sendfile == ENABLE_SENDFILE_OFF)
             ? 0 : APR_SENDFILE_ENABLED);
#endif

It was removed because in the absence of APR_HAS_SENDFILE, it gave a
compiler warning. The real fix was to surround it in an ifdef, which has
been done.

Regards,
Graham
--



Mime
View raw message