Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 39467 invoked from network); 26 Sep 2006 19:48:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Sep 2006 19:48:23 -0000 Received: (qmail 68272 invoked by uid 500); 26 Sep 2006 19:48:20 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 68229 invoked by uid 500); 26 Sep 2006 19:48:19 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 68218 invoked by uid 99); 26 Sep 2006 19:48:19 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Sep 2006 12:48:19 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=minfrin@sharp.fm; spf=pass X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received-SPF: pass (idunn.apache.osuosl.org: domain sharp.fm designates 64.49.220.200 as permitted sender) Received: from [64.49.220.200] ([64.49.220.200:40015] helo=chandler.sharp.fm) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 45/C0-15364-30489154 for ; Tue, 26 Sep 2006 12:48:19 -0700 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id AE5DAE54DB for ; Tue, 26 Sep 2006 14:48:16 -0500 (CDT) Received: from [192.168.200.34] (firstmarine.cust-gw.jnb6.alter.net [196.31.24.162]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by chandler.sharp.fm (Postfix) with ESMTP id 111F0E54D8 for ; Tue, 26 Sep 2006 14:48:14 -0500 (CDT) Message-ID: <451983FC.2020103@sharp.fm> Date: Tue, 26 Sep 2006 21:48:12 +0200 From: Graham Leggett User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h References: <20060926162657.88A171A981A@eris.apache.org> <45197D97.8050101@apache.org> In-Reply-To: <45197D97.8050101@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Ruediger Pluem wrote: >> +#define CACHE_BUF_SIZE 65536 >> + > > Is it really a got idea to store 64k on the stack? Shouldn't we get this memory from a pool? +1. Regards, Graham --