Return-Path: 
 <dev-return-54895-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@www.apache.org
Received: (qmail 25199 invoked from network); 26 Sep 2006 13:53:32 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 26 Sep 2006 13:53:32 -0000
Received: (qmail 71008 invoked by uid 500); 26 Sep 2006 13:53:28 -0000
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 70813 invoked by uid 500); 26 Sep 2006 13:53:28 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
List-Post: <mailto:dev@httpd.apache.org>
List-Id: <dev.httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 70802 invoked by uid 99); 26 Sep 2006 13:53:28 -0000
Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org)
 (140.211.166.84)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Sep 2006 06:53:28 -0700
X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=
Received: from [209.237.227.194] ([209.237.227.194:61757]
 helo=minotaur.apache.org)
	by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP
	id B4/01-11437-7D039154 for <dev@httpd.apache.org>;
 Tue, 26 Sep 2006 06:53:27 -0700
Received: (qmail 25132 invoked by uid 2161); 26 Sep 2006 13:53:24 -0000
Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4])
	by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id
 0E15D1721C
	for <dev@httpd.apache.org>; Tue, 26 Sep 2006 15:53:15 +0200 (CEST)
Message-ID: <451930D5.5080403@apache.org>
Date: Tue, 26 Sep 2006 15:53:25 +0200
From: Ruediger Pluem <rpluem@apache.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417
X-Accept-Language: de, en, de-de, en-gb, cy, zu, xh
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r450042 - in /httpd/httpd/trunk: CHANGES
 modules/cache/mod_disk_cache.c
 modules/cache/mod_disk_cache.h
References: <20060926132910.418A81A981A@eris.apache.org>
In-Reply-To: <20060926132910.418A81A981A@eris.apache.org>
X-Enigmail-Version: 0.90.2.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N



On 09/26/2006 03:29 PM, wrote:
> Author: minfrin
> Date: Tue Sep 26 06:29:09 2006
> New Revision: 450042
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=450042
> Log:
> mod_disk_cache: Make sure that only positive integers are accepted
> for the CacheMaxFileSize and CacheMinFileSize parameters in the
> config file. PR39380 [Niklas Edmundsson <nikke acc.umu.se>]
> 

> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_disk_cache.h?view=diff&rev=450042&r1=450041&r2=450042
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.h (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.h Tue Sep 26 06:29:09 2006
> @@ -88,8 +88,8 @@
>      apr_size_t cache_root_len;
>      int dirlevels;               /* Number of levels of subdirectories */
>      int dirlength;               /* Length of subdirectory names */
> -    apr_size_t minfs;            /* minumum file size for cached files */
> -    apr_size_t maxfs;            /* maximum file size for cached files */
> +    apr_off_t minfs;             /* minimum file size for cached files */
> +    apr_off_t maxfs;             /* maximum file size for cached files */
>  } disk_cache_conf;
>  

Maybe stupid question, but the disk_cache_conf is not part of the API, right? Otherwise I guess we would
need to have some sort of bump here (and I would guess a major one).

Regards

Rüdiger