httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject Re: svn commit: r450188 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Date Wed, 27 Sep 2006 09:13:11 GMT
On Wed, 27 Sep 2006, Graham Leggett wrote:

> Ruediger Pluem wrote:
>
>> Are we sure that we do not iterate too often (> 100) over this during the 
>> lifetime
>> of a request? I would say 'No, we do not iterate too often', but I think a 
>> crosscheck
>> by someone else is a good idea. Otherwise we would have a potential 
>> temporary memory
>> leak here.
>
> We would copy the body once per request, surely? That's how I read it - 
> copy_body would be called once, resulting in the buffer being declared once, 
> and reused inside the copy_body loop.

The code is very picky about there only being a single, complete, 
body so it should only be called once per request.

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  I am Jay Leno of Borg : Kevin's love life is irrelevant (and non-existing)
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Mime
View raw message