httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r451580 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Date Sat, 30 Sep 2006 13:35:40 GMT

On Sep 30, 2006, at 7:04 AM, mturk@apache.org wrote:

> Author: mturk
> Date: Sat Sep 30 04:04:46 2006
> New Revision: 451580
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=451580
> Log:
> Add alternative is_socket_connected implementation.
> It works on win32 and linux for sure, so that's why
> I put it inside the #ifdef.
> Of course something like that needs APR abstraction.
>

I'm not sure about this... is the patch complete or are
other things being added at some point? For example:

>
> +#if defined(WIN32) || defined(LINUX)
> +#define USE_ALTERNATE_IS_CONNECTED 1
> +#else
> +#define USE_ALTERNATE_IS_CONNECTED 0
> +#endif
> +
> +#if USE_ALTERNATE_IS_CONNECTED
> +static int is_socket_connected(apr_socket_t *socket)
...
> +        rc = select((int)sock + 1, &fd, NULL, NULL, &tv);
> +#if defined(WIN32) || (defined(NETWARE) && defined(__NOVELL_LIBC__))
> +        errno = WSAGetLastError() - WSABASEERR;
> +#endif
> +    } while (rc == -1 && errno == EINTR);

what's the 'defined(NETWARE) && defined(__NOVELL_LIBC__))'
doing there?

Also, does this mean that the "current" impl does NOT
work for Windows and Linux?


Mime
View raw message