httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r451575 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h proxy_util.c
Date Sat, 30 Sep 2006 11:23:01 GMT


On 09/30/2006 12:41 PM,  wrote:
> Author: mturk
> Date: Sat Sep 30 03:41:51 2006
> New Revision: 451575
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=451575
> Log:
> Enable retry=0 for the worker.
> This allows to have an option to always retry
> the workers in error state instead using a
> specified time.
> 

> 
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.h?view=diff&rev=451575&r1=451574&r2=451575
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Sat Sep 30 03:41:51 2006
> @@ -296,6 +296,7 @@
>  struct proxy_worker {
>      int             id;         /* scoreboard id */
>      apr_interval_time_t retry;  /* retry interval */
> +    char            retry_set;
>      int             lbfactor;   /* initial load balancing factor */
>      const char      *name;
>      const char      *scheme;    /* scheme to use ajp|http|https */
> 

IMHO this struct is part of the public API. So changing it requires a bump. Please add new
members of the struct
to the end of the struct to avoid a major bump which would cause this change not to be backportable.
Furthermore I think adding a new member to the struct can be avoided completely by initializing
retry to apr_time_from_sec(PROXY_WORKER_DEFAULT_RETRY) in ap_proxy_add_worker and removing
this code
from ap_proxy_initialize_worker.

Regards

RĂ¼diger

Mime
View raw message