httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r450188 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Date Wed, 27 Sep 2006 08:12:38 GMT


On 09/27/2006 12:22 AM, Graham Leggett wrote:
> Ruediger Pluem wrote:
> 
>> Are we sure that we do not iterate too often (> 100) over this during
>> the lifetime
>> of a request? I would say 'No, we do not iterate too often', but I
>> think a crosscheck
>> by someone else is a good idea. Otherwise we would have a potential
>> temporary memory
>> leak here.
> 
> 
> We would copy the body once per request, surely? That's how I read it -
> copy_body would be called once, resulting in the buffer being declared
> once, and reused inside the copy_body loop.

Yes, of course. Stupid thought of mine. It had been already too late and I was too
tired :-). Thanks for review anyway.

Regards

RĂ¼diger


Mime
View raw message