httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h
Date Tue, 26 Sep 2006 19:20:55 GMT


On 09/26/2006 06:26 PM, wrote:
> Author: minfrin
> Date: Tue Sep 26 09:26:56 2006
> New Revision: 450105
> 
> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_disk_cache.c?view=diff&rev=450105&r1=450104&r2=450105
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Sep 26 09:26:56 2006
> @@ -157,7 +157,16 @@

> +
> +static apr_status_t copy_body(apr_file_t *srcfd, apr_off_t srcoff, 
> +                              apr_file_t *destfd, apr_off_t destoff, 
> +                              apr_off_t len)
> +{
> +    apr_status_t rc;
> +    apr_size_t size;
> +    apr_finfo_t finfo;
> +    apr_time_t starttime = apr_time_now();
> +    char buf[CACHE_BUF_SIZE];
> +

> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.h (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.h Tue Sep 26 09:26:56 2006
> @@ -28,6 +28,8 @@
>  #define CACHE_DATA_SUFFIX   ".data"
>  #define CACHE_VDIR_SUFFIX   ".vary"
>  
> +#define CACHE_BUF_SIZE 65536
> +

Is it really a got idea to store 64k on the stack? Shouldn't we get this memory from a pool?

Regards

RĂ¼diger



Mime
View raw message