httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c
Date Wed, 13 Sep 2006 19:33:46 GMT


On 09/13/2006 01:44 AM,  wrote:
> Author: niq
> Date: Tue Sep 12 16:44:12 2006
> New Revision: 442758
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=442758
> Log:
> PR 31759 (mutated) - reported by Jo Rhett
> Don't return apr_status_t error value from input filter chain.
> 
> Modified:
>     httpd/httpd/trunk/modules/generators/mod_cgi.c
>     httpd/httpd/trunk/modules/generators/mod_cgid.c
> 
> Modified: httpd/httpd/trunk/modules/generators/mod_cgi.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgi.c?view=diff&rev=442758&r1=442757&r2=442758
> ==============================================================================
> --- httpd/httpd/trunk/modules/generators/mod_cgi.c (original)
> +++ httpd/httpd/trunk/modules/generators/mod_cgi.c Tue Sep 12 16:44:12 2006
> @@ -837,7 +837,9 @@
>                              APR_BLOCK_READ, HUGE_STRING_LEN);
>  
>          if (rv != APR_SUCCESS) {
> -            return rv;
> +            ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
> +                          "Error reading request entity data");
> +            return HTTP_INTERNAL_SERVER_ERROR;
>          }
>  


Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case that c->aborted
is set,
just like in the default handler?

Regards

RĂ¼diger

Mime
View raw message