httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] mod_disk_cache working LFS (filecopy)
Date Tue, 26 Sep 2006 11:00:50 GMT
On Tue, Sep 26, 2006 at 10:52:18AM +0200, Niklas Edmundsson wrote:
> 
> This patch depends on "mod_disk_cache LFS-aware config" submitted 
> earlier and is for trunk.
> 
> It makes caching of large files possible on 32bit machines by:
> 
> * Realising that a file is a file and can be copied as such, without
>   reading the whole thing into memory first.

This was discussed a while back.  I think this is an API problem which 
needs to be fixed at API level, not something which should be worked 
around by adding bucket-type-specific hacks.  The "store_body" callback 
needs to be able to operate like a real output filter so it can avoid 
the buffering-buckets-into-memory problem; as in:

while (brigade not empty)
1. read data from bucket
2. write data to disk
3. pass bucket up output filter chain
4. delete bucket

Regards,

joe

Mime
View raw message