httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [patch 10/16] fix up coding style issues
Date Wed, 20 Sep 2006 09:20:35 GMT
Hi Davi,

On Tue, Sep 19, 2006 at 11:34:03PM -0300, Davi Arnaut wrote:
> Clean up code style in the cache code and shrink the mod_mem_cache
> store_body function.

The casts to/from void * are unnecessary and could just be removed 
rather than being whitespace-adjusted.

> --- modules/cache/mod_mem_cache.c.orig
> +++ modules/cache/mod_mem_cache.c
> @@ -52,27 +52,30 @@
>  
>  module AP_MODULE_DECLARE_DATA mem_cache_module;
>  
> -typedef enum {
> +typedef enum
> +{

The traditional style is to keep the brace on the same line for data 
type definitions (but not with function definitions).  see e.g. "grep 
struct httpd.h" :)

Regards,

joe

Mime
View raw message