Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jfclere@gmail.com designates
 64.233.182.191 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding;
        b=Hi2rkAduIFkkbPOzDNrBZDGKXyrGHjrSIeIOtOxZ9uQc5SeeKABENb0pVlclvWuefkny9mQJhyJgkGi3qNs2mJnt4hSVCsi9GyebyvVesViH9Sp+qkRHd/ujOehcYGQ5PPXI2m9LOB9iqY12ZhqUGAe/08YfiFwTEWMImHE3Dmk=
Message-ID: <44D273C1.3070006@gmail.com>
Date: Fri, 04 Aug 2006 00:08:01 +0200
From: Jean-frederic Clere <jfclere@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.7.13) Gecko/20060620 Debian/1.7.13-0.2
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r428437 -
 /httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
References: <20060803160151.C3AE01A981A@eris.apache.org>
 <44D251D3.6080107@apache.org>
In-Reply-To: <44D251D3.6080107@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Ruediger Pluem wrote:

>On 08/03/2006 06:01 PM, jfclere@apache.org wrote:
>  
>
>>Author: jfclere
>>Date: Thu Aug  3 09:01:50 2006
>>New Revision: 428437
>>
>>URL: http://svn.apache.org/viewvc?rev=428437&view=rev
>>Log:
>>Use only one slotmem for status and checker.
>>
>>Modified:
>>    httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
>>
>>Modified: httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
>>URL: http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c?rev=428437&r1=428436&r2=428437&view=diff
>>==============================================================================
>>--- httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c (original)
>>+++ httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c Thu Aug  3 09:01:50 2006
>>@@ -40,13 +40,19 @@
>> {
>>     const health_worker_method *worker_storage;
>>     worker_storage = ap_lookup_provider(PROXY_CKMETHOD, "default", "0");
>>+    proxy_server_conf *sconf = ap_get_module_config(s->module_config,
>>+                                                    &proxy_module);
>>+    char *slotmem_loc = sconf->slotmem_loc;
>>     
>>     if (worker_storage) {
>>         apr_status_t rv;
>>-        rv = worker_storage->create_slotmem("proxy/checker", ap_proxy_lb_workers(), pconf);
>>+        if (!slotmem_loc)
>>+            slotmem_loc = apr_pstrcat(pconf, ":", proxy_module.name, NULL);
>>+
>>+        rv = worker_storage->create_slotmem(slotmem_loc, ap_proxy_lb_workers(), pconf);
>>    
>>
>
>Sorry for being confused, but in one case you store a (struct proxy_worker_conf) in this slotmemory and
>in proxy_util you use the same area to store a proxy_worker_stat entry. So as far as I understand it you
>store different structures, with different sizes in the same memory. Does this really work?
>  
>
This works, but there is another problem (also in trunk) that I have not 
solved yet:
- in httpd.conf change the workers (add one in top for example).
- make graceful restart
- go to /server-status/
The information about workers (Access/Read/Write) is wrong. With the 
persistance I have added you have to remove the *.slotmem file to 
arrange it, in trunk a stop and a start helps.
To solve that I am thinking of using ap_md5_binary on the worker_conf list.

Comments?

Cheers

Jean-Frederic

>Regards
>
>Rüdiger
>
>  
>